]> dgit.raspbian.org Git - gnome-shell.git/commit
calendar-server: Fix double-free detection abort
authorGustavo Noronha Silva <gustavo@noronha.dev.br>
Tue, 18 May 2021 18:28:43 +0000 (15:28 -0300)
committerGustavo Noronha Silva <gustavo@noronha.dev.br>
Tue, 18 May 2021 23:06:50 +0000 (23:06 +0000)
commit404ca91941226faaf2479609f0109244e66d4bcd
tree1ed66cfdf96e21e78d77fd200e087b8485ecf11f
parentd9239e2cee27cad582544e769ad794ca571f35fb
calendar-server: Fix double-free detection abort

app_notify_events_added uses an intermediate builder to construct an
array that is then added to the main variant using g_variant_builder_add
which should clear the intermediate, but doesn't due to the way it is
passed: by value, rather than as a pointer.

This was debugged with the help of Eduardo Habkost, who believes it
works on x86 due to big structs being passed as pointers.

Fixed: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3440
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1848>
src/calendar-server/gnome-shell-calendar-server.c